On Tue, 14 Nov 2023 00:35:57 +0100, Linus Walleij wrote: > When adding a proper schema for the Marvell mx88e6xxx switch, > the scripts start complaining about this embedded example: > > dtschema/dtc warnings/errors: > net/marvell,mvusb.example.dtb: switch@0: ports: '#address-cells' > is a required property > from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml# > net/marvell,mvusb.example.dtb: switch@0: ports: '#size-cells' > is a required property > from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml# > > Fix this up by extending the example with those properties in > the ports node. > > While we are at it, rename "ports" to "ethernet-ports" and rename > "switch" to "ethernet-switch" as this is recommended practice. > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> > Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/marvell,mvusb.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: /example-0/usb/mdio@1/ethernet-switch@0: failed to match any schema with compatible: ['marvell,mv88e6190'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231114-marvell-88e6152-wan-led-v8-2-50688741691b@xxxxxxxxxx The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
