On Monday 12 January 2015 15:28:53 Zhou Wang wrote: > Signed-off-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx> > --- I haven't looked at earlier versions, but it looks very good to me overall. Just add a patch description above please. One tiny detail: > +static const struct of_device_id nfc_id_table[] = { > + { .compatible = "hisilicon,504-nfc" }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, nfc_id_table); > + > +static struct platform_driver hisi_nfc_driver = { > + .driver = { > + .name = "hisi_nand", > + .of_match_table = of_match_ptr(nfc_id_table), > + .pm = &hisi_nfc_pm_ops, > + }, > + .probe = hisi_nfc_probe, > + .remove = hisi_nfc_remove, > +}; Remove the of_match_ptr() macro here to avoid a warning when CONFIG_OF is not set. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html