On Fri, Nov 10, 2023 at 03:50:18PM +0100, Krzysztof Kozlowski wrote: > On 09/11/2023 22:20, Frank Li wrote: > > In i.MX95's edma version 5, the TCD structure is extended to support 64-bit > > addresses for fields like saddr and daddr. To prevent code duplication, > > employ help macros to handle the fields, as the field names remain the same > > between TCD and TCD64. > > > > Change local variables related to TCD addresses from 'u32' to 'dma_addr_t' > > to accept 64-bit DMA addresses. > > > > Change 'vtcd' type to 'void *' to avoid direct use. Use helper macros to > > access the TCD fields correctly. > > > > Call 'dma_set_mask_and_coherent(64)' when TCD64 is supported. > > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > > --- > > Three kbuild reports with build failures. > > I have impression this was never build-tested and reviewed internally > before posting. We had such talk ~month ago and I insisted on some > internal review prior submitting to mailing list. I did not insist on > internal building of patches, because it felt obvious, so please kindly > thoroughly build, review and test your patches internally, before using > the community for this. I am pretty sure NXP can build the code they send. This build error happen at on special uncommon platform m6800. Patch is tested in imx95 arm64 platform. I have not machine to cover all platform. Frank > > Thank you in advance. > > Best regards, > Krzysztof >
