> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Wednesday, November 8, 2023 4:13 PM > To: David Airlie <airlied@xxxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; > Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard > <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>; > Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley > <conor+dt@xxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Andi > Shyti <andi.shyti@xxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>; Lars- > Peter Clausen <lars@xxxxxxxxxx>; Lee Jones <lee@xxxxxxxxxx>; Ulf > Hansson <ulf.hansson@xxxxxxxxxx>; Tomasz Figa <tomasz.figa@xxxxxxxxx>; > Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>; Linus Walleij > <linus.walleij@xxxxxxxxxx>; Thierry Reding <thierry.reding@xxxxxxxxx>; Uwe > Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Alessandro Zummo > <a.zummo@xxxxxxxxxxxx>; Alexandre Belloni > <alexandre.belloni@xxxxxxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx>; Jiri Slaby <jirislaby@xxxxxxxxxx>; Liam > Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; > Jaehoon Chung <jh80.chung@xxxxxxxxxxx>; Sam Protsenko > <semen.protsenko@xxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux- > i2c@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; > linux-gpio@xxxxxxxxxxxxxxx; linux-pwm@xxxxxxxxxxxxxxx; linux- > rtc@xxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx; alsa-devel@alsa- > project.org; linux-sound@xxxxxxxxxxxxxxx > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Subject: [PATCH 01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add > specific compatibles for existing SoC > > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine and > there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like compatibles. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > --- > > I propose to take the patch through Samsung SoC (me). See cover letter for > explanation. > --- > .../bindings/hwinfo/samsung,exynos-chipid.yaml | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos- > chipid.yaml > b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml > index 95cbdcb56efe..45f3d468db7c 100644 > --- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos- > chipid.yaml > +++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos- > chipid.yam > +++ l > @@ -11,9 +11,20 @@ maintainers: > > properties: > compatible: > - enum: > - - samsung,exynos4210-chipid > - - samsung,exynos850-chipid > + oneOf: > + - enum: > + - samsung,exynos4210-chipid > + - samsung,exynos850-chipid > + - items: > + - enum: > + - samsung,exynos5433-chipid > + - samsung,exynos7-chipid > + - const: samsung,exynos4210-chipid > + - items: > + - enum: > + - samsung,exynos7885-chipid > + - samsung,exynosautov9-chipid > + - const: samsung,exynos850-chipid > > reg: > maxItems: 1 > -- > 2.34.1
