Hi Anshul, thanks for your patch! Overall this looks good to me. On Thu, Nov 9, 2023 at 10:07 AM Anshul Dalal <anshulusr@xxxxxxxxx> wrote: > Implements driver for the Ambient/UV Light sensor LTR390. > The driver exposes two ways of getting sensor readings: > 1. Raw UV Counts directly from the sensor > 2. The computed UV Index value with a percision of 2 decimal places > > NOTE: Ambient light sensing has not been implemented yet. > > Datasheet: > https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf > > Driver tested on RPi Zero 2W > > Signed-off-by: Anshul Dalal <anshulusr@xxxxxxxxx> (...) > +#define LTR390_FRCTIONAL_PERCISION 100 This define is just too hard for me to read, can you rename it? Does it mean LTR390_FRACTIONAL_PRECISION? It's fine to spell it out like that instead. Yours, Linus Walleij
