On 09.11.23 09:53, Krzysztof Kozlowski wrote: > On 08/11/2023 16:37, Javier Carrasco wrote: >> Add device tree bindings and an example for the ChipCap 2 humidity >> and temperature sensor. >> >> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> >> --- >> .../bindings/hwmon/amphenol,chipcap2.yaml | 68 ++++++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/hwmon/amphenol,chipcap2.yaml b/Documentation/devicetree/bindings/hwmon/amphenol,chipcap2.yaml >> new file mode 100644 >> index 000000000000..8bb6daa293d3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/amphenol,chipcap2.yaml >> @@ -0,0 +1,68 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/hwmon/amphenol,chipcap2.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: ChipCap 2 humidity and temperature iio sensor >> + >> +maintainers: >> + - Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> >> + >> +description: | >> + Relative humidity and temperature sensor on I2C bus. >> + >> + Datasheets: >> + https://www.amphenol-sensors.com/en/telaire/humidity/527-humidity-sensors/3095-chipcap-2 >> + >> +properties: >> + compatible: >> + enum: >> + - amphenol,cc2dxx >> + - amphenol,cc2dxxs >> + > > Nothing improved. > > Really, you just ignored the review. > > Best regards, > Krzysztof > I am sorry if I missed something from your first review. I changed the interrupt description to have one per item as you suggested and removed the empty line. I did not change the compatible enum to add all part numbers because it was still under discussion, but now that I know that I have to add all of them, I will change for the next version. Best regards, Javier Carrasco
