On Mon, Nov 06, 2023 at 02:15:12PM +0200, Dmitry Baryshkov wrote: > On Mon, 6 Nov 2023 at 14:11, Dang Huynh <danct12@xxxxxxxxxx> wrote: > > > > The PM8937 is found on boards with MSM8917, MSM8937, MSM8940 SoCs and > > APQ variants. > > > > It provides 6 SMPS (two are controlled by SPMI) and 23 LDO regulators. > > > > Signed-off-by: Dang Huynh <danct12@xxxxxxxxxx> > > I haven't checked LDO / SMPS types. That's kind of the part where one would most likely make mistakes though. :D I checked them based on the log Dang posted on IRC, by cross-referencing the voltage ranges with the regulator types in the SPMI regulator driver. Looks good :) Reviewed-by: Stephan Gerhold <stephan@xxxxxxxxxxx> Thanks, Stephan (bootloader) Detected PMIC 0x10019 (bootloader) s1: 1225000 mV, disabled, fast (smps) (bootloader) s2: 1162500 mV, enabled, fast (smps) (bootloader) s3: 1412500 mV, enabled, fast (smps) (bootloader) s4: 2050000 mV, enabled, fast (smps) (bootloader) s5: 1225000 mV, enabled, fast (ftsmps2p5) (bootloader) s6: 1225000 mV, enabled, fast (ftsmps2p5) (bootloader) l1: 1000000 mV, disabled, normal (ult_nldo) (bootloader) l2: 1250000 mV, enabled, normal (ult_nldo) (bootloader) l3: 1350000 mV, enabled, idle (ult_nldo) (bootloader) l4: 1800000 mV, disabled, normal (ult_pldo) (bootloader) l5: 1800000 mV, enabled, idle (ult_pldo) (bootloader) l6: 1800000 mV, enabled, normal (ult_pldo) (bootloader) l7: 1800000 mV, enabled, normal (ult_pldo) (bootloader) l8: 2900000 mV, enabled, normal (ult_pldo) (bootloader) l9: 3300000 mV, disabled, normal (ult_pldo) (bootloader) l10: 2800000 mV, disabled, normal (ult_pldo) (bootloader) l11: 2950000 mV, enabled, normal (ult_pldo) (bootloader) l12: 2950000 mV, enabled, normal (ult_pldo) (bootloader) l13: 3075000 mV, enabled, normal (ult_pldo) (bootloader) l14: 1800000 mV, disabled, normal (ult_pldo) (bootloader) l15: 1800000 mV, disabled, normal (ult_pldo) (bootloader) l16: 1800000 mV, disabled, normal (ult_pldo) (bootloader) l17: 2850000 mV, enabled, normal (ult_pldo) (bootloader) l18: 2700000 mV, disabled, normal (ult_pldo) (bootloader) l19: 1300000 mV, disabled, normal (ult_nldo) (bootloader) l20: 1740000 mV, disabled (ln_ldo) (bootloader) l21: 1740000 mV, disabled (ln_ldo) (bootloader) l22: 2800000 mV, disabled, normal (ult_pldo) (bootloader) l23: 1300000 mV, disabled, normal (nldo1)