Re: [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 06, 2023 at 04:13:24PM +0100, Alexander Stein wrote:
> Use #pwm-cells for all i.MX variants. Only fsl,imx1-pwm does not support
> inverted PWM output. Keep it the same for consistency.
> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> index c01dff3b7f843..a84a240a61dc1 100644
> --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> @@ -14,12 +14,10 @@ allOf:
>  
>  properties:
>    "#pwm-cells":
> -    description: |
> -      Should be 2 for i.MX1 and 3 for i.MX27 and newer SoCs. See pwm.yaml
> -      in this directory for a description of the cells format.
> -    enum:
> -      - 2
> -      - 3
> +    description:
> +      The only third cell flag supported by this binding is
> +      PWM_POLARITY_INVERTED. fsl,imx1-pwm does not support this flags.
> +    const: 3

You dropped the | from the description line, but with my understanding
of yaml this should be fine.

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux