On Fri 2015-01-09 16:23:05, Jacek Anaszewski wrote:
> This patch adds helper functions for registering/unregistering
> LED Flash class devices as V4L2 sub-devices. The functions should
> be called from the LED subsystem device driver. In case the
> support for V4L2 Flash sub-devices is disabled in the kernel
> config the functions' empty versions will be used.
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>
> Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Cc: Sakari Ailus <sakari.ailus@xxxxxx>
> Cc: Hans Verkuil <hans.verkuil@xxxxxxxxx>
Acked-by: Pavel Machek <pavel@xxxxxx>
> + /*
> + * Indicator leds, unlike torch leds, are turned on/off basing
> on
leds -> LEDs.
> + * the state of V4L2_CID_FLASH_INDICATOR_INTENSITY control only.
> + * Therefore it must be possible to set it to 0 level which in
> + * the LED subsystem reflects LED_OFF state.
> + */
> + if (cdata_id != INDICATOR_INTENSITY)
> + ++__intensity;
And normally we'd do i++ instead of ++i, and avoid __ for local
variables...?
> +/**
> + * struct v4l2_flash_ctrl_config - V4L2 Flash controls initialization data
> + * @intensity: constraints for the led in a non-flash mode
> + * @flash_intensity: V4L2_CID_FLASH_INTENSITY settings constraints
> + * @flash_timeout: V4L2_CID_FLASH_TIMEOUT constraints
> + * @flash_faults: possible flash faults
> + * @has_external_strobe: external strobe capability
> + * @indicator_led: signifies that a led is of indicator type
> + */
> +struct v4l2_flash_ctrl_config {
> + struct v4l2_ctrl_config intensity;
> + struct v4l2_ctrl_config flash_intensity;
> + struct v4l2_ctrl_config flash_timeout;
> + u32 flash_faults;
> + bool has_external_strobe:1;
> + bool indicator_led:1;
> +};
I don't think you are supposed to do boolean bit arrays.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
