On Sun, Nov 05, 2023 at 09:24:09AM -0400, Jason Gunthorpe wrote:
> On Fri, Nov 03, 2023 at 05:48:01PM -0700, Jerry Snitselaar wrote:
> > > @@ -1632,10 +1633,15 @@ int acpi_dma_configure_id(struct device *dev, enum dev_dma_attr attr,
> > >
> > > acpi_arch_dma_setup(dev);
> > >
> > > - iommu = acpi_iommu_configure_id(dev, input_id);
> > > - if (PTR_ERR(iommu) == -EPROBE_DEFER)
> > > + ret = acpi_iommu_configure_id(dev, input_id);
> > > + if (ret == -EPROBE_DEFER)
> > > return -EPROBE_DEFER;
> > >
> > return ret; ?
>
> Maybe? Like this seemed to be a pattern in this code so I left it
Yeah, it is fine. I think it just caught my eye, because of this earlier
bit in the patch:
if (err == -EPROBE_DEFER) {
- return ERR_PTR(err);
+ return err;
which needed to get rid of the ERR_PTR.
Regards,
Jerry
>
> > > + /*
> > > + * Historically this routine doesn't fail driver probing due to errors
> > > + * in acpi_iommu_configure()
> >
> > acpi_iommu_configure_id()
>
> Thanks
>
> Jason
