On Wed, Nov 01, 2023 at 05:24:45PM +0300, Dmitry Rokosov wrote:
> AW200XX controllers have the capability to declare more than 0xf LEDs,
> therefore, it is necessary to accept LED names using an appropriate
> regex pattern.
>
> The register offsets can be adjusted within the specified range, with
> the maximum value corresponding to the highest number of LEDs that can
> be connected to the controller.
>
> Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx")
> Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxxxxx>
You did correctly guess what I was getting at on the previous version.
Apologies for not replying - I got sick and things probably fell a bit
through the cracks.
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Cheers,
Conor.
> ---
> .../bindings/leds/awinic,aw200xx.yaml | 64 +++++++++++++++++--
> 1 file changed, 58 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> index 67c1d960db1d..ba4511664fb8 100644
> --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> @@ -45,17 +45,12 @@ properties:
> maxItems: 1
>
> patternProperties:
> - "^led@[0-9a-f]$":
> + "^led@[0-9a-f]+$":
> type: object
> $ref: common.yaml#
> unevaluatedProperties: false
>
> properties:
> - reg:
> - description:
> - LED number
> - maxItems: 1
> -
> led-max-microamp:
> default: 9780
> description: |
> @@ -69,6 +64,63 @@ patternProperties:
> where max-current-switch-number is determinated by led configuration
> and depends on how leds are physically connected to the led driver.
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: awinic,aw20036
> + then:
> + patternProperties:
> + "^led@[0-9a-f]+$":
> + properties:
> + reg:
> + items:
> + minimum: 0
> + maximum: 36
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: awinic,aw20054
> + then:
> + patternProperties:
> + "^led@[0-9a-f]+$":
> + properties:
> + reg:
> + items:
> + minimum: 0
> + maximum: 54
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: awinic,aw20072
> + then:
> + patternProperties:
> + "^led@[0-9a-f]+$":
> + properties:
> + reg:
> + items:
> + minimum: 0
> + maximum: 72
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: awinic,aw20108
> + then:
> + patternProperties:
> + "^led@[0-9a-f]+$":
> + properties:
> + reg:
> + items:
> + minimum: 0
> + maximum: 108
> +
> required:
> - compatible
> - reg
> --
> 2.36.0
>
Attachment:
signature.asc
Description: PGP signature
