Le mercredi 01 novembre 2023 à 15:10 +0000, Conor Dooley a écrit : > On Wed, Nov 01, 2023 at 11:22:56AM +0100, Vincent Knecht wrote: > > Document AK7345 bindings. > > The commit message should mention why this device is incompatible with > the 7375. Something like > > "Document the ak7345 voice coil motor actuator. Similar to the ak7375, > this model has 4 unilateral phase detractors instead of 8." > > Otherwise, > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Cheers, > Conor. Thank you for the review! I don't know anything about phase detractors, nor any other details (having found no datasheets for either of these ICs) apart what could be infered from vendor/downstream drivers like in the commit text for patch 3/3... So I guess I'll send a v2 with a commit text along these lines : Document AK7345 bindings. Compared to AK7375, it has only 9 bits position values (instead of 12), 20 ms power-up delay (instead of 10), and no known standby register setting.