On Wed, Nov 01, 2023 at 07:38:39AM +0600, Binbin Zhou wrote:
> On Tue, Oct 31, 2023 at 10:58 PM Conor Dooley <conor@xxxxxxxxxx> wrote:
> >
> > On Tue, Oct 31, 2023 at 07:05:49PM +0800, Binbin Zhou wrote:
> > > Add the missing 'thermal-sensor-cells' property which is required for
> > > every thermal sensor as it's used when using phandles.
> > > And add the thermal-sensor.yaml reference.
> > >
> > > Fixes: 72684d99a854 ("thermal: dt-bindings: add loongson-2 thermal")
> > > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
> > > ---
> > > .../bindings/thermal/loongson,ls2k-thermal.yaml | 10 +++++++++-
> > > 1 file changed, 9 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml
> > > index 7538469997f9..b634f57cd011 100644
> > > --- a/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml
> > > +++ b/Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml
> > > @@ -10,6 +10,9 @@ maintainers:
> > > - zhanghongchen <zhanghongchen@xxxxxxxxxxx>
> > > - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
> > >
> > > +allOf:
> > > + - $ref: /schemas/thermal/thermal-sensor.yaml#
> > > +
> > > properties:
> > > compatible:
> > > oneOf:
> > > @@ -26,12 +29,16 @@ properties:
> > > interrupts:
> > > maxItems: 1
> > >
> > > + '#thermal-sensor-cells':
> > > + const: 1
> > > +
> > > required:
> > > - compatible
> > > - reg
> > > - interrupts
> > > + - '#thermal-sensor-cells'
> >
> > Why does it need to be a required property now though?
> > Adding new required properties is technically an ABI break.
>
> Hi Conor:
>
> I don't think it makes sense to have a separate thermal sensor
> definition, it needs thermal-zones to describe specific behaviors,
> e.g. cpu-thermal, so we need '#thermal-sensor-cells' to specify the
> reference.
> And the Loongson-2K1000 has 4 sets of control registers, we need to
> specify the id when referencing it.
Unfortunately, none of this is an answer to my question.
Attachment:
signature.asc
Description: PGP signature
