On 31/10/2023 13:03, Md Sadre Alam wrote:
Eh? Empty?
> Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx>
> Signed-off-by: Sricharan R <quic_srichara@xxxxxxxxxxx>
> ---
> drivers/mtd/nand/Kconfig | 7 ++
> drivers/mtd/nand/Makefile | 1 +
> drivers/mtd/nand/ecc-qcom.c | 198 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 206 insertions(+)
> create mode 100644 drivers/mtd/nand/ecc-qcom.c
>
...
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(qcom_ecc_config);
> +
> +void qcom_ecc_enable(struct qcom_ecc *ecc)
> +{
> + ecc->use_ecc = true;
> +}
> +EXPORT_SYMBOL(qcom_ecc_enable);
Drop this and all other exports. Nothing here explains the need for them.
> +
> +void qcom_ecc_disable(struct qcom_ecc *ecc)
> +{
> + ecc->use_ecc = false;
> +}
> +EXPORT_SYMBOL(qcom_ecc_disable);
> +
> +static const struct of_device_id qpic_ecc_dt_match[] = {
> + {
> + .compatible = "qcom,ipq9574-ecc",
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
Checkpatch is preerquisite. Don't send patches which have obvious issues
pointed out by checkpatch. It's a waste of reviewers time.
> + },
> + {},
> +};
> +
> +static int qpic_ecc_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct qpic_ecc *ecc;
> + u32 max_eccdata_size;
> +
> + ecc = devm_kzalloc(dev, sizeof(*ecc), GFP_KERNEL);
> + if (!ecc)
> + return -ENOMEM;
> +
> + ecc->caps = of_device_get_match_data(dev);
> +
> + ecc->dev = dev;
> + platform_set_drvdata(pdev, ecc);
> + dev_info(dev, "probed\n");
No, no such messages.
Best regards,
Krzysztof
