On Mon, Oct 30, 2023 at 06:00:08PM +0800, Moudy Ho wrote: > To simplify maintenance and avoid branches, the identical component > should be merged and placed in the path belonging to the MDP > (from display/* to media/*). > > In addition, currently only MDP utilizes RDMA through CMDQ, and the > necessary properties for "mediatek,gce-events", and "mboxes" have been > set up for this purpose. > Within DISP, it directly receives component interrupt signals. > > Signed-off-by: Moudy Ho <moudy.ho@xxxxxxxxxxxx> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > --- > .../display/mediatek/mediatek,mdp-rdma.yaml | 88 ------------------- > .../bindings/media/mediatek,mdp3-rdma.yaml | 55 +++++++++--- > 2 files changed, 45 insertions(+), 98 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > index 3e128733ef53..c043204cf210 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > @@ -20,8 +20,9 @@ description: | > > properties: > compatible: > - items: > - - const: mediatek,mt8183-mdp3-rdma > + enum: > + - mediatek,mt8183-mdp3-rdma > + - mediatek,mt8195-vdo1-rdma > > reg: > maxItems: 1 > @@ -49,17 +50,18 @@ properties: > maxItems: 1 > > clocks: > - items: > - - description: RDMA clock > - - description: RSZ clock > + minItems: 1 > + maxItems: 2 Keep the description here and just add 'minItems: 1' and... > > iommus: > maxItems: 1 > > mboxes: > - items: > - - description: used for 1st data pipe from RDMA > - - description: used for 2nd data pipe from RDMA > + minItems: 1 > + maxItems: 2 > + > + interrupts: > + maxItems: 1 > > '#dma-cells': > const: 1 > @@ -68,13 +70,46 @@ required: > - compatible > - reg > - mediatek,gce-client-reg > - - mediatek,gce-events > - power-domains > - clocks > - iommus > - - mboxes > - '#dma-cells' > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8183-mdp3-rdma > + > + then: > + properties: > + clocks: > + items: > + - description: RDMA clock > + - description: RSZ clock (shared SRAM with RDMA) Then just need 'minItems: 2' here and... > + > + mboxes: > + items: > + - description: used for 1st data pipe from RDMA > + - description: used for 2nd data pipe from RDMA > + > + required: > + - mboxes > + - mediatek,gce-events > + > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8195-vdo1-rdma > + > + then: > + properties: > + clocks: > + items: > + - description: RDMA clock 'maxItems: 1' here. The same thing applies to mboxes. Rob
