On 30/10/2023 11:19, Mrinmay Sarkar wrote: > > On 10/27/2023 7:20 PM, Krzysztof Kozlowski wrote: >> On 27/10/2023 15:33, Mrinmay Sarkar wrote: >>> Add devicetree bindings support for SA8775P SoC. It has DMA register >>> space and dma interrupt to support HDMA. >>> >>> Signed-off-by: Mrinmay Sarkar <quic_msarkar@xxxxxxxxxxx> >> Unfortunately I do not see any of my comment addressed. :( >> >> This is a friendly reminder during the review process. >> >> It seems my or other reviewer's previous comments were not fully >> addressed. Maybe the feedback got lost between the quotes, maybe you >> just forgot to apply it. Please go back to the previous discussion and >> either implement all requested changes or keep discussing them. >> >> Thank you. >> >> Best regards, >> Krzysztof > Thanks Krzysztof for your review and patience. > Sorry I missed your previous comment. Multiple comments. Also from Mani and maybe from others? > > If I understand correctly by constraining IO space/interrupt, > you mean to add maxItems for reg and interrupt for other variants. > If so, I verified adding maxItems for these properties and dtb check > seems to be good. I will post the same in the next patch series. > > Thanks, > Mrinmay >> Best regards, Krzysztof
