On 29/10/2023 16:09, Nik Bune wrote: > Hello! > >> On Sun, 29 Oct 2023 at 08:31, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> On 28/10/2023 19:51, Nik Bune wrote: >>>>> + power-domains: >>>>> + description: >>>>> + A phandle and PM domain specifier as defined by bindings of >>>>> + the power controller specified by phandle. >>>>> + See Documentation/devicetree/bindings/power/power-domain.yaml for details. >>>> >>>> I think you missed Rob's comment in reply to Andrew, about constraining >>>> and ordering the power-domains: >>>> https://lore.kernel.org/all/20231026203037.GA327324-robh@xxxxxxxxxx/ >>>> >>>> Cheers, >>>> Conor. >>> >>> I didn't get what should be done with respect to the comment above: >>> Should we wait for the response from Andrew, >>> or should we skip and remove the the power-domains definition for this binding, >>> or add "maxItems: 1" to power-domains definition? >> >> None of the options above allow to send the same code without maxItems. >> Sending new version without addressing feedback is basically ignoring >> the feedback and next time you will have annoyed reviewers... >> >> Best regards, >> Krzysztof >> > > I didn't ignore. v3 patch was sent 37 minutes before the Rob's comment to v2. Ah, sorry, it's good then :). Rob's comment still applies, though. Best regards, Krzysztof
