Re: [PATCH v2 1/6] dt-bindings: regulator: add Samsung s2dos05 pmic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



сб, 28 окт. 2023 г. в 23:17, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx>:
>
> On 28/10/2023 18:01, Dzmitry Sankouski wrote:
> > вт, 24 окт. 2023 г. в 18:59, Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx>:
> > ....
> >>> +title: Samsung s2dos05 regulator
> >>
> >> Not a PMIC/MFD device? If not, then:
> >> Samsung S2DOS05 Power Management IC
> >>
> >> Otherwise, if this is only for regulators:
> >> Samsung S2DOS05 Power Management IC Regulators
> >>
> > AFAIU, PMIC/MFD would be a device, with more than one function.
> > Analysing s2dos05 vendor code it's capable of generating interrupts
> > and measure current(which I'm planning to implement as a hwmon module).
> > There're regulators with interrupt functionality in linux. Since
> > current measurement
> > feature would be in hwmon subsystem, can we consider s2dos05 NOT a PMIC/MFD
> > device?
>
> These PMICs often have also RTC, USB connector, battery charger and/or
> fuel-gauge. If the main function is PMIC, keeping it in regulators seem
> fine. The bindings should be complete though (or at least ready for more
> features), so you should investigate hwmon or fuel-gauge now.
>
The right place for s2dos05 current measuring functionality is hwmon,
because fuel gauge term is for ICs determining the current State of
Charge of accumulators.
Hwmon modules doesn't rely on device tree binding, but on '.*_detect' functions,
so the binding would be fine.





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux