On 28/10/2023 14:10, Vincent Knecht wrote: > When adding in the indexes for this clock-controller we missed > GCC_CAMSS_CSI2_AHB_CLK, GCC_CAMSS_CSI2_CLK, GCC_CAMSS_CSI2PHY_CLK, > GCC_CAMSS_CSI2PIX_CLK and GCC_CAMSS_CSI2RDI_CLK. > > Add them in now. > > Signed-off-by: Vincent Knecht <vincent.knecht@xxxxxxxxxx> > --- > No fixes tag because camss is a not-yet-enabled feature for msm8939. > > Also didn't rename ftbl_gcc_camss_csi0_1_clk now that csi2 uses it > to avoid not-required-churn... should it be done anyway ? > --- > drivers/clk/qcom/gcc-msm8939.c | 104 +++++++++++++++++++ > include/dt-bindings/clock/qcom,gcc-msm8939.h | 6 ++ Bindings must be a separate patch. Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
