On 25/10/2023 10:20, Wei-Shih Lin wrote: > This patch adds device tree bindings for Novatek NT519XX series > touchscreen devices. > > Signed-off-by: Wei-Shih Lin <Weishih_Lin@xxxxxxxxxxxxxx> > --- > .../input/touchscreen/novatek,nt519xx.yaml | 60 +++++++++++++++++++ > MAINTAINERS | 9 +++ > 2 files changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/novatek,nt519xx.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/novatek,nt519xx.yaml b/Documentation/devicetree/bindings/input/touchscreen/novatek,nt519xx.yaml > new file mode 100644 > index 000000000000..00912e265197 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/novatek,nt519xx.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/novatek,nt519xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Novatek nt519xx touchscreen controller bindings Except that it was never tested... > + > +maintainers: > + - Wei-Shih Lin <Weishih_Lin@xxxxxxxxxxxxxx> > + - Leo LS Chang <Leo_LS_Chang@xxxxxxxxxxxxxx> > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + enum: > + - novatek,NVT-ts That's not a real compatible. Nope. Open existing code to find examples. > + > + reg: > + maxItems: 1 > + > + novatek,irq-gpio: No drop. Use interrupts > + maxItems: 1 > + > + novatek,reset-gpio: > + maxItems: 1 Really, please start from scratch from existing, recent bindings. This must be generic reset-gpios. > + > + touchscreen-size-x: true > + touchscreen-size-y: true > + > +required: > + - compatible > + - reg > + - novatek,irq-gpio > + - novatek,reset-gpio > + - touchscreen-size-x > + - touchscreen-size-y > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/gpio/gpio.h> > + i2c { > + novatek@62 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof
