On Fri, Oct 27, 2023 at 11:15 AM Niklas Cassel <Niklas.Cassel@xxxxxxx> wrote: > > Hello Rob, > > On Fri, Oct 27, 2023 at 10:58:28AM -0500, Rob Herring wrote: > > On Fri, Oct 27, 2023 at 9:56 AM Niklas Cassel <nks@xxxxxxxxxxx> wrote: > > > > > > From: Niklas Cassel <niklas.cassel@xxxxxxx> > > > > > > Even though rockchip-dw-pcie.yaml inherits snps,dw-pcie.yaml > > > using: > > > > > > allOf: > > > - $ref: /schemas/pci/snps,dw-pcie.yaml# > > > > > > and snps,dw-pcie.yaml does have the atu reg defined, in order to be > > > able to use this reg, while still making sure 'make CHECK_DTBS=y' > > > pass, we need to add this reg to rockchip-dw-pcie.yaml. > > > > > > All compatible strings (rockchip,rk3568-pcie and rockchip,rk3588-pcie) > > > should have this reg. > > > > > > The regs in the example are updated to actually match pcie3x2 on rk3568. > > > > Breaking compatibility on these platforms is okay because ...? > > I don't follow, could you please elaborate? A DT which was valid without 'atu' region is now not valid with this change. If I'm reading this schema with the change, then not having 'atu' is an error and the OS can treat it as an error. If it does, then it wouldn't work with existing DTs. You cannot add new required properties or required entries. If you can say no users of the affected platforms care (e.g. only you have a board) or the binding is not yet in use, then it's fine. But you have to state that justification. I suspect that is not the case here. Rob
