On Thu, Oct 26, 2023 at 02:36:10PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Thu, Oct 26, 2023 at 11:11:53AM +0000, Sakari Ailus wrote:
> > On Tue, Oct 10, 2023 at 10:24:03AM +0200, Alain Volmat wrote:
> > > From: Hugues Fruchet <hugues.fruchet@xxxxxxxxxxx>
> > >
> > > This V4L2 subdev driver enables Digital Camera Memory Interface
> > > Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series.
> > >
> > > Signed-off-by: Hugues Fruchet <hugues.fruchet@xxxxxxxxxxx>
> > > Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
> > > ---
> > > drivers/media/platform/st/stm32/Kconfig | 15 +
> > > drivers/media/platform/st/stm32/Makefile | 1 +
> > > .../platform/st/stm32/stm32-dcmipp/Makefile | 4 +
> > > .../st/stm32/stm32-dcmipp/dcmipp-bytecap.c | 916 ++++++++++++++++++
> > > .../st/stm32/stm32-dcmipp/dcmipp-byteproc.c | 555 +++++++++++
> > > .../st/stm32/stm32-dcmipp/dcmipp-common.c | 106 ++
> > > .../st/stm32/stm32-dcmipp/dcmipp-common.h | 216 +++++
> > > .../st/stm32/stm32-dcmipp/dcmipp-core.c | 603 ++++++++++++
> > > .../st/stm32/stm32-dcmipp/dcmipp-parallel.c | 441 +++++++++
> > > 9 files changed, 2857 insertions(+)
> > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/Makefile
> > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
> > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c
> > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.c
> > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h
> > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
> > > create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c
>
> [snip]
>
> > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
> > > new file mode 100644
> > > index 000000000000..4f784c5791e7
> > > --- /dev/null
> > > +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
> > > @@ -0,0 +1,916 @@
>
> [snip]
>
> > > +static const struct dcmipp_bytecap_pix_map *
> > > +dcmipp_bytecap_pix_map_by_pixelformat(u32 pixelformat)
> > > +{
> > > + unsigned int i;
> > > +
> > > + for (i = 0; i < ARRAY_SIZE(dcmipp_bytecap_pix_map_list); i++) {
> >
> > No need for braces. Up to you.
>
> For what it's worth, I usually ask for braces in my reviews for these
> kind of cases :-)
Well, if you read the coding style document, you may find this, but people
don't interpret it as strictly anymore anyway. I think it's fine without.
--
Sakari Ailus
