> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Wednesday, October 4, 2023 12:11 PM
> To: Pankaj Gupta <pankaj.gupta@xxxxxxx>; shawnguo@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; clin@xxxxxxxx;
> conor+dt@xxxxxxxxxx; pierre.gondois@xxxxxxx; festevam@xxxxxxxxx; dl-
> linux-imx <linux-imx@xxxxxxx>; davem@xxxxxxxxxxxxx;
> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Gaurav Jain <gaurav.jain@xxxxxxx>;
> alexander.stein@xxxxxxxxxxxxxxx; Varun Sethi <V.Sethi@xxxxxxx>
> Subject: [EXT] Re: [PATCH v6 07/11] firmware: imx: add driver for NXP
> EdgeLock Enclave
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On 27/09/2023 19:53, Pankaj Gupta wrote:
> > The Edgelock Enclave , is the secure enclave embedded in the SoC to
> > support the features like HSM, SHE & V2X, using message based
> > communication channel.
> >
> > ELE FW communicates on a dedicated MU with application core where
> > kernel is running. It exists on specific i.MX processors. e.g.
> > i.MX8ULP, i.MX93.
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@xxxxxxx>
>
> Where is the user-space tool? Please include it in the commit msg. We talked
> about this already.
>
It is included as part of "Documentation/ABI/testing/se-cdev".
I will add it in the commit message too.
> > ---
> > Documentation/ABI/testing/se-cdev | 41 +
> > drivers/firmware/imx/Kconfig | 12 +
>
>
> ...
>
> > +
> > + ret = ele_mu_request_channel(dev, &priv->rx_chan,
> > + &priv->ele_mb_cl, info->mbox_rx_name);
> > + if (ret) {
> > + if (ret != -EPROBE_DEFER)
> > + dev_err(dev, "Failed to request rx channel\n");
> > +
> > + goto exit;
> > + }
> > +
> > + priv->ctxs = devm_kzalloc(dev, sizeof(dev_ctx) * priv->max_dev_ctx,
> > + GFP_KERNEL);
> > +
> > + if (!priv->ctxs) {
> > + ret = -ENOMEM;
> > + dev_err(dev, "Fail allocate mem for private
> > + dev-ctxs.\n");
>
> So you ignored the feedback... I assume you ignored it all, so:
>
> NAK
>
> Please go back and implement the feedback.
I will remove the dev_err prints for memory allocations.
If still needed, will convert the dev_err to dev_dbg.
>
> Best regards,
> Krzysztof
