On 25/10/23 21:27, Nishanth Menon wrote: > On 16:32-20231025, Nitin Yadav wrote: >> Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according >> to AM62a SK datasheet. The Link of datasheet is in the following line: > > SK? line? > > Please rephrase above and just mention the section of the data sheet to > refer to. > >> >> https://www.ti.com/lit/gpn/am62a3 >> >> Section: 6.3.10 GPIO (Page No. 52-55) > >> >> Fixes: '5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")' > > What is the single quote for? > Also note the additional comment in the list to drop the extra EoL. > > > Did you check the MCU and WKUP GPIO count as well? if there are bugs > around it, fix it in a single commit please. yes, checked they are good. > >> >> Signed-off-by: Nitin Yadav <n-yadav@xxxxxx> >> --- >> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> index 3198af08fb9f..de36abb243f1 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi >> @@ -462,7 +462,7 @@ main_gpio0: gpio@600000 { >> <193>, <194>, <195>; >> interrupt-controller; >> #interrupt-cells = <2>; >> - ti,ngpio = <87>; >> + ti,ngpio = <92>; >> ti,davinci-gpio-unbanked = <0>; >> power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>; >> clocks = <&k3_clks 77 0>; >> @@ -480,7 +480,7 @@ main_gpio1: gpio@601000 { >> <183>, <184>, <185>; >> interrupt-controller; >> #interrupt-cells = <2>; >> - ti,ngpio = <88>; >> + ti,ngpio = <52>; >> ti,davinci-gpio-unbanked = <0>; >> power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>; >> clocks = <&k3_clks 78 0>; >> -- >> 2.25.1 >> > -- Regards, Nitin
