Hi Sato-san, On Wed, Oct 25, 2023 at 1:14 PM Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 18 Oct 2023 23:27:43 +0900, > Geert Uytterhoeven wrote: > > On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato > > <ysato@xxxxxxxxxxxxxxxxxxxx> wrote: > > > Renesas SuperH binding definition. > > > > > > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/sh/cpus.yaml > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > > Missing > > > > - jcore,j2 > > > > > + - renesas,sh4 > > > > > > > + - const: renesas,sh > > > > I see arch/sh/boot/dts/j2_mimas_v2.dts lacks the fallback to > > "renesas,sh", though. > > Is there a common base of instructions that are available on all SH cores? > > The base instruction set is sh2. > Before that, there is sh1, but this is not compatible with Linux. > I think it would be a good idea to change this to "renesas,sh2", > but the SH7619 (SH2 CPU) would look like the following. > cpus { > cpu: cpu@0 { > compatible = "renesas,sh2", "renesas,sh2"; > }; > }; SH7619 would just use a single compatible value: compatible = "renesas,sh2". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds