Re: [PATCH v3 2/2] i2c: mv64xxx: add an optional reset-gpios property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/10/23 08:18, Andi Shyti wrote:
> Hi Chris,
>
> as you are working on the v4...
>
> ...
>
>> +	if (drv_data->reset_gpio) {
>> +		usleep_range(reset_duration, reset_duration + 10);
> I'm not against this, but it's not optimal unless we know more or
> less what to expect from reset_duration.
>
> Do we have a rough idea of what reset_duration is? If we don't
> then you could consider using a generic "fsleep(reset_duration);"
> Would it work?
flseep() would work for me. All of the devices I'm testing with seem to 
be fine with a very short reset pulse, they'd probably be fine with no 
delay at all.
>
> Rest looks good.
>
> Andi




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux