On Tue, Oct 24, 2023 at 03:18:13PM +0200, Linus Walleij wrote: > On Tue, Oct 24, 2023 at 2:48 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, 24 Oct 2023 11:24:53 +0200, Linus Walleij wrote: > > > Bindings using dsa.yaml#/$defs/ethernet-ports specify that > > > a DSA switch node need to have a ports or ethernet-ports > > > subnode, and that is actually required, so add requirements > > > using oneOf. > > > > > > Suggested-by: Rob Herring <robh@xxxxxxxxxx> > > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:60:5: [warning] wrong indentation: expected 6 but found 4 (indentation) > > ./Documentation/devicetree/bindings/net/dsa/dsa.yaml:62:5: [warning] wrong indentation: expected 6 but found 4 (indentation) > > Oh yeah Krzysztof actually explained to me why these have to have > two spaces extra. > > Oh well I just keep hitting the robot for testing this. > > Yours, > Linus Walleij FWIW, we have a rule in Documentation/process/maintainer-netdev.rst to not repost more frequently than once every 24 hours. Unfortunately I don't have a huge review capacity right now, so in my case it could probably take even a bit more than that. But it's a bit unpleasant that I left some feedback on v4, you posted v5 yesterday and since then we're now at v7, only for me to find that I need to repeat my v4 feedback.
