On Tue, Oct 24, 2023 at 8:17 AM Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote:
> > Add makomo sku0 and sku1 which uses different audio codec.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index fe8c488a3207..b131e0bdbf01 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -250,6 +250,18 @@ properties:
> > - google,kodama-sku32
> > - const: google,kodama
> > - const: mediatek,mt8183
> > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2)
> > + items:
> > + - const: google,makomo-rev4-sku0
> > + - const: google,makomo-rev5-sku0
>
> With these bindings, how does one describe a makomo-rev5-sku0?
> What you have here is only suitable for describing the makomo-rev4-sku0.
>
makomo-rev5-sku0 and makomo-rev4-sku0 uses the same dts:
compatible = "google,makomo-rev4-sku0", "google,makomo-rev5-sku0",
"google,makomo", "mediatek,mt8183";
In this case, can bindings be listed like that?
> Cheers,
> Conor.
>
> > + - const: google,makomo
> > + - const: mediatek,mt8183
> > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2)
> > + items:
> > + - const: google,makomo-rev4-sku1
> > + - const: google,makomo-rev5-sku1
> > + - const: google,makomo
> > + - const: mediatek,mt8183
> > - description: Google Willow (Acer Chromebook 311 C722/C722T)
> > items:
> > - enum:
> > --
> > 2.42.0.758.gaed0368e0e-goog
> >
