Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code
From: Raymond Hackley <raymondhackley@xxxxxxxxxxxxxx>
Date: Tue, 24 Oct 2023 12:37:26 +0000
Cc: alim.akhtar@xxxxxxxxxxx, conor+dt@xxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, krzysztof.kozlowski+dt@xxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, raymondhackley@xxxxxxxxxxxxxx, robh+dt@xxxxxxxxxx, ~postmarketos/upstreaming@xxxxxxxxxxx
Feedback-id: 49437091:user:proton
In-reply-to: <bc5bbf47-7bcb-4fc6-a88b-b92d74803a7a@linaro.org>

Hi Krzysztof,

This key-ok is the hardware middle button on midas, and there is also
touchkey, which already provides <KEY_BACK KEY_MENU>, so I assume the other
KEY_MENU in key-ok is duplicated. Fixing it with KEY_OK as the node name
implies would make more sense.

Regards,
Raymond

Follow-Ups:
- Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code
  - From: Krzysztof Kozlowski

References:
- [PATCH v2 0/2] ARM: dts: samsung: exynos4412-midas: fix key-ok and use Linux event codes
  - From: Raymond Hackley
- [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code
  - From: Raymond Hackley
- Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code
  - From: Krzysztof Kozlowski

Prev by Date: Re: [PATCH v11 06/14] dt-bindings: interrupt-controller: Add RISC-V incoming MSI controller
Next by Date: Re: [PATCH V2 3/4] ASoC: codecs: Add code for bin parsing compatible with aw88399
Previous by thread: Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code
Next by thread: Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code
Index(es):
- Date
- Thread

[Index of Archives] [Device Tree Compilter] [Device Tree Spec] [Linux Driver Backports] [Video for Linux] [Linux USB Devel] [Linux PCI Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86] [Yosemite Backpacking]