On Mon, Oct 23, 2023 at 04:27:48PM +0200, Nuno Sá wrote: > On Mon, 2023-10-23 at 17:05 +0300, Ramona Gradinariu wrote: > > The adis16460 device requires a stall time between SPI > > transactions (during which the chip select is inactive), > > with a minimum value equal to 16 microseconds. > > This commit adds 'spi-cs-inactive-delay-ns' property, which should > > indicate the stall time between consecutive SPI transactions. > > > > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@xxxxxxxxxx> > > --- > > changes in v2: > > - added default value > > - updated description > > - updated commit message > > .../devicetree/bindings/iio/imu/adi,adis16460.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > index 4e43c80e5119..f10469b86ee0 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > @@ -25,6 +25,12 @@ properties: > > > > spi-cpol: true > > > > + spi-cs-inactive-delay-ns: > > + minimum: 16000 > > + default: 16000 > > + description: > > + Indicates the stall time between consecutive SPI transactions. > > + > > You should drop the description... > > Also, give more time before posting a v2 so others get a chance to review your > patches. It's also better for you since you can gather more change requests. Further, I don't see an answer to Krzysztof's question of why the stall time would not just be set to 16,000 ns in the driver, based on the compatible.
Attachment:
signature.asc
Description: PGP signature
