On 23/10/2023 14:19, Zhenhua Huang wrote: > > > On 2023/10/23 19:46, Krzysztof Kozlowski wrote: >> On 23/10/2023 13:43, Zhenhua Huang wrote: >>>>> + >>>>> + mem_dump_apply_offset(&dump_vaddr, &phys_addr, >>>>> + size + QCOM_DUMP_DATA_SIZE); >>>>> + if (phys_addr > phys_end_addr) { >>>>> + dev_err_probe(dev, -ENOMEM, "Exceeding allocated region\n"); >>>> >>>> ENOMEM? Does not look right then. >>> >>> ENOMEM means the memory allocated not enough? any suggestion? Thanks. >> >> The error code is okay, but we rarely need to print error messages for >> memory allocation failures. Core prints it already. > > It's not same as below case. Allocation is successful here, while the > driver used more than allocated size. $ man errno ENOMEM means: Not enough space/cannot allocate memory Best regards, Krzysztof