On Fri, Oct 20, 2023 at 1:50 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 20/10/2023 05:49, Jyan Chou wrote: > > Document the device-tree bindings for Realtek SoCs mmc driver. > > > > Signed-off-by: Jyan Chou <jyanchou@xxxxxxxxxxx> > > > > --- > > v2 -> v3: > > - Modify dt-bindings' content and description. > > - Fix coding style. > > - Update the list of maintainers. > > > > v0 -> v2: > > - Add dt-bindings. > > --- > > --- > > .../bindings/mmc/realtek-dw-mshc.yaml | 150 ++++++++++++++++++ > > 1 file changed, 150 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml > > > > diff --git a/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml > > new file mode 100644 > > index 000000000000..b1e37fb37be9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/realtek-dw-mshc.yaml > > Filename matching compatible. > > BTW, before you respond, be sure you have fixed your email client. In > your last response everything was not properly wrapped (not matching > mailing list discussion style). > > > @@ -0,0 +1,150 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mmc/realtek-dw-mshc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Realtek designware mobile storage host controller > > > DesignWare > > > + > > +description: > > + Realtek uses the Synopsys designware mobile storage host controller > > DesignWare > > > + to interface a SoC with storage medium. This file documents the Realtek > > + specific extensions. > > + > > +allOf: > > + - $ref: synopsys-dw-mshc-common.yaml# > > + > > +maintainers: > > + - Jyan Chou <jyanchou@xxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - realtek,rtd-dw-cqe-emmc > > Compatibles should have SoC-specific part. It does not look like you > have one here. > > Missing blank line > > > + reg: > > + maxItems: 2 > > You need to describe the items. > > > + > > + reg-names: > > + maxItems: 2 > > You need to describe the items. > > > + > > + interrupts: > > + maxItems: 1 > > + > > + cqe: > > + maxItems: 1 > > Looks like some custom property. If it is a generic one, where is it > documented? If it is custom, missing vendor prefix and description. > Detailed description. There's common properties related to CQE. Use them. Rob
