On Thu, 19 Oct 2023 19:54:09 +0300, Vladimir Oltean wrote: > So user ports and CPU ports meet at ksz8_port_setup() from different > call paths, but I think it's strange to continue this coding pattern for > port stuff that's not common between user ports and CPU ports. For that > reason, the placement of the existing ksz8795_cpu_interface_select() is > also weird, when it could have been directly placed under > ksz8_config_cpu_port(), and it would have not confusingly shared a code > path with user ports. > > Could you please add a dedicated ksz88x3_config_rmii_clk(), called > directly from ksz8_config_cpu_port()? It can have this as first step: > > if (!ksz_is_ksz88x3(dev)) > return 0; > > and then the rest of the code can have a single level of indentation, > which would look much more natural. Ok, will do. I am guessing I should leave the existing ksz8795_cpu_interface_select() as it is?
