On 20/10/2023 04:51, Tao Zhang wrote: > Correct the property name of the DSB MSR number that needs to be > read in TPDM driver. The right property name is > "qcom,dsb-msrs-num". Missing Fixes tag. > > This patch depends on patch series "Add support to configure TPDM DSB > subunit" > https://patchwork.kernel.org/project/linux-arm-kernel/list/?series=788353 This is not suitable for commit msg. Dependencies are noted under ---. And how is this depending on that patch? Your buggy code was applied long time ago! > > Signed-off-by: Tao Zhang <quic_taozha@xxxxxxxxxxx> > --- > drivers/hwtracing/coresight/coresight-tpdm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c > index b25284e..97654aa 100644 > --- a/drivers/hwtracing/coresight/coresight-tpdm.c > +++ b/drivers/hwtracing/coresight/coresight-tpdm.c > @@ -892,7 +892,7 @@ static int tpdm_probe(struct amba_device *adev, const struct amba_id *id) > > if (drvdata && tpdm_has_dsb_dataset(drvdata)) > of_property_read_u32(drvdata->dev->of_node, > - "qcom,dsb_msr_num", &drvdata->dsb_msr_num); > + "qcom,dsb-msrs-num", &drvdata->dsb_msr_num); So you never tested your DTS... We can keep asking about this but still testing does not happen :/ Best regards, Krzysztof
