On Thu, Oct 19, 2023 at 02:28:50PM +0200, Oleksij Rempel wrote: > Ensures a stable PME (Power Management Event) pin state by disabling PME > on system start and enabling it on shutdown only if WoL (Wake-on-LAN) is > configured. This is needed to avoid issues with some PMICs (Power > Management ICs). > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > --- > index fa8d0318b437..9e6f1e4b57b7 100644 > --- a/drivers/net/dsa/microchip/ksz9477.h > +++ b/drivers/net/dsa/microchip/ksz9477.h > @@ -62,6 +62,7 @@ void ksz9477_get_wol(struct ksz_device *dev, int port, > struct ethtool_wolinfo *wol); > int ksz9477_set_wol(struct ksz_device *dev, int port, > struct ethtool_wolinfo *wol); > +void ksz9477_wol_pre_shutdown(struct ksz_device *dev, bool *wol_is_on); nitpick: Please synchronize the prototype definition with the declaration (the name of the "wol_is_on" argument differs). > > int ksz9477_port_acl_init(struct ksz_device *dev, int port); > void ksz9477_port_acl_free(struct ksz_device *dev, int port); Otherwise: Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
