Hi Sato-san, On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote: > Renesas SuperH SH7751R common definition. > > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/arch/sh/boot/dts/sh7751r.dtsi > @@ -0,0 +1,148 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Source for the SH7751R SoC > + */ > + > +#include <dt-bindings/interrupt-controller/sh_intc.h> > +#include <dt-bindings/clock/sh7750.h> > + > +/ { > + #address-cells = <1>; > + #size-cells = <1>; > + > + cpus { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cpu@0 { > + compatible = "renesas,sh4", "renesas,sh"; > + device_type = "cpu"; > + reg = <0>; > + clocks = <&cpg SH7750_CPG_ICK>; > + clock-names = "ick"; > + icache-size = <16384>; > + icache-line-size = <32>; > + dcache-size = <32768>; > + dcache-line-size = <32>; Wrong indentation (2 TABs and 6 spaces instead of 3 TABs). > + }; > + }; > + > + xtal: oscillator { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <0>; > + clock-output-names = "xtal"; > + }; > + > + soc { > + scif1: serial@ffe80000 { > + compatible = "renesas,scif-sh7751", "renesas,scif"; > + reg = <0xffe80000 0x100>; > + interrupts = <evt2irq(0x700) 0>, > + <evt2irq(0x720) 0>, > + <evt2irq(0x760) 0>, > + <evt2irq(0x740) 0>; > + interrupt-names = "eri", "rxi", "txi", "bri"; > + clocks = <&cpg SH7750_CPG_SCIF_CLK>; > + clock-names = "fck"; > + power-domains = <&cpg>; status = "disabled"; and add &scif1 { status = "okay"; }; to each board .dts file that uses scif1. > + }; > + pcic: pci@fe200000 { > + compatible = "renesas,pci-sh7751"; > + #address-cells = <3>; > + #size-cells = <2>; > + #interrupt-cells = <1>; > + device_type = "pci"; > + bus-range = <0 0>; > + ranges = <0x02000000 0 0xfd000000 0xfd000000 0 0x01000000>, > + <0x01000000 0 0x00000000 0xfe240000 0 0x00040000>; > + reg = <0xfe200000 0x0400>, > + <0x0c000000 0x04000000>, > + <0xff800000 0x0030>; status = "disabled"; and add &pcic { status = "okay"; }; to each board .dts file that uses pcic. > + }; > + }; > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds