Hi Sato-san, On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote: > SH7751 interrupt controller binding definition. > > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/renesas,sh7751-intc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas SH7751 Interrupt Controller > + > +maintainers: > + - Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> > + > +properties: > + compatible: > + items: > + - const: renesas,sh7751-intc > + > + '#interrupt-cells': > + # an interrupt index and flags, as defined in interrupts.txt in > + # this directory I think you can drop this comment. > + const: 2 > +examples: > + - | Missing #include <dt-bindings/interrupt-controller/sh_intc.h> Please run make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/renesas,sh7751-intc.yaml to catch such issues before posting. > + shintc: interrupt-controller@ffd00000 { Please align this to the "|" above, and use 4 spaces for each additional indentation step. > + compatible = "renesas,sh7751-intc"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
