On 2023/10/18 19:30, Conor Dooley wrote:
> On Wed, Oct 11, 2023 at 07:05:08PM +0800, Minda Chen wrote:
>> PolarFire Implements none-PLDA event interrupts. So the whole event
>> domain ops can not be re-used.
>
> IIRC, the reason things are like this is to work around the lack of an
> msi controller and are not as a result of changes made to the PLDA IP
> by us.
>
Oh. For this reason that new added interrupts have to add to
global events field, not the MSI. I will add this to commit messages.
Thanks
>> PLDA event domain ops instances will be implemented
>> in later patch.
>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>
> Thanks,
> Conor.
>
>>
>> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
>> ---
>> drivers/pci/controller/plda/pcie-microchip-host.c | 9 ++++++---
>> drivers/pci/controller/plda/pcie-plda.h | 1 +
>> 2 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pci/controller/plda/pcie-microchip-host.c b/drivers/pci/controller/plda/pcie-microchip-host.c
>> index fca1520d56c9..2825c1f5563d 100644
>> --- a/drivers/pci/controller/plda/pcie-microchip-host.c
>> +++ b/drivers/pci/controller/plda/pcie-microchip-host.c
>> @@ -811,13 +811,15 @@ static const struct plda_event_ops mc_event_ops = {
>> };
>>
>> static const struct plda_event mc_event = {
>> + .domain_ops = &mc_event_domain_ops,
>> .event_ops = &mc_event_ops,
>> .request_event_irq = mc_request_event_irq,
>> .intx_event = EVENT_LOCAL_PM_MSI_INT_INTX,
>> .msi_event = EVENT_LOCAL_PM_MSI_INT_MSI,
>> };
>>
>> -static int plda_pcie_init_irq_domains(struct plda_pcie_rp *port)
>> +static int plda_pcie_init_irq_domains(struct plda_pcie_rp *port,
>> + const struct irq_domain_ops *ops)
>> {
>> struct device *dev = port->dev;
>> struct device_node *node = dev->of_node;
>> @@ -831,7 +833,8 @@ static int plda_pcie_init_irq_domains(struct plda_pcie_rp *port)
>> }
>>
>> port->event_domain = irq_domain_add_linear(pcie_intc_node, port->num_events,
>> - &mc_event_domain_ops, port);
>> + ops, port);
>> +
>> if (!port->event_domain) {
>> dev_err(dev, "failed to get event domain\n");
>> of_node_put(pcie_intc_node);
>> @@ -930,7 +933,7 @@ static int plda_init_interrupts(struct platform_device *pdev,
>> return -EINVAL;
>> }
>>
>> - ret = plda_pcie_init_irq_domains(port);
>> + ret = plda_pcie_init_irq_domains(port, event->domain_ops);
>> if (ret) {
>> dev_err(dev, "failed creating IRQ domains\n");
>> return ret;
>> diff --git a/drivers/pci/controller/plda/pcie-plda.h b/drivers/pci/controller/plda/pcie-plda.h
>> index 6571a4befac9..080932cbe8c4 100644
>> --- a/drivers/pci/controller/plda/pcie-plda.h
>> +++ b/drivers/pci/controller/plda/pcie-plda.h
>> @@ -129,6 +129,7 @@ struct plda_pcie_rp {
>> };
>>
>> struct plda_event {
>> + const struct irq_domain_ops *domain_ops;
>> const struct plda_event_ops *event_ops;
>> int (*request_event_irq)(struct plda_pcie_rp *pcie,
>> int event_irq, int event);
>> --
>> 2.17.1
>>
