Hi Sato-san, On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote: > Renesas SuperH based target definition. > > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! Please use a one-line prefix that matches the history of the other files next to it: dt-bindings: soc: renesas: Document SH7751 based targets > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/renesas/sh.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/renesas/sh.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas SuperH Platform > + > +maintainers: > + - Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: RTS7751R2D Plus > + items: > + - enum: > + - renesas,rts7751r2d # Renesas SH4 2D graphics board > + - const: renesas,sh7751r > + > + - description: Julian board > + items: > + - enum: > + - iodata,landisk # LANDISK HDL-U > + - iodata,usl-5p # USL-5P These depend on "[RFC PATCH v3 27/35] Documentation/devicetree/bindings: vendor-prefix add IO DATA DEVICE Inc.", so that patch should be moved forward in the series. > + - const: renesas,sh7751r Please merge both sections, as they use the same number of compatible values and the same fallback. > + > +additionalProperties: true > + > +... > -- > 2.39.2 > -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds