On 18/10/2023 16:25, Nia Espera wrote: > Document the devicetree bindings for oneplus-lemonade and oneplus-lemonadep. A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Nia Espera <nespera@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index adbfaea32343..72832ee5b876 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -974,6 +974,8 @@ properties: > - qcom,sm8350-mtp > - sony,pdx214-generic > - sony,pdx215-generic > + - oneplus,lemonade > + - oneplus,lemonadep Wrong order. 'o' does not go after 's'. Best regards, Krzysztof