On Wed, 18 Oct 2023 15:52:27 +0200, Andrew Lunn wrote: > It looks like this is the only use of dev->rmii_clk_internal? So does > it actually need to be a member of ksz_device? Yes, I guess you are right, sorry about that, it probably won't be used later on and should be removed from ksz_device. I will repost if the rest of the patch is ok?