Hi Sato-san, On Sat, Oct 14, 2023 at 4:54 PM Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote: > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/renesas,sh7750-cpg.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas SH7750/7751 Clock Pulse Generator (CPG) > + > +maintainers: > + - Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> > + > +description: > + The Clock Pulse Generator (CPG) generates core clocks for the SoC. It > + includes PLLs, and variable ratio dividers. > + > + The CPG may also provide a Clock Domain for SoC devices, in combination with > + the CPG Module Stop (MSTP) Clocks. > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,sh7750-cpg # SH7750 > + - renesas,sh7750s-cpg # SH775S > + - renesas,sh7750r-cpg # SH7750R > + - renesas,sh7751-cpg # SH7751 > + - renesas,sh7751r-cpg # SH7751R > + - const: renesas,sh7750-cpg As there are important differences between the CPG variants, I think it makes sense to drop the "renesas,sh7750-cpg", fallback, like you BTW already did in the example below. Then you can drop the "items", and just keep "enum". > +examples: > + - | > + #include <dt-bindings/clock/sh7750.h> > + cpg: clock-controller@ffc00000 { > + #clock-cells = <1>; > + #power-domain-cells = <0>; > + compatible = "renesas,sh7751r-cpg"; > + clocks = <&xtal>; > + clock-names = "xtal"; > + reg = <0xffc00000 20>, <0xfe0a0000 16>; $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.yaml Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.example.dtb: clock-controller@ffc00000: compatible: ['renesas,sh7751r-cpg'] is too short from schema $id: http://devicetree.org/schemas/clock/renesas,sh7750-cpg.yaml# Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.example.dtb: clock-controller@ffc00000: 'reg-names' is a required property from schema $id: http://devicetree.org/schemas/clock/renesas,sh7750-cpg.yaml# > + }; > -- > 2.39.2 > -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
