Re: [PATCH V2 3/4] clk: qcom: Add ECPRICC driver support for QDU1000 and QRU1000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/13/2023 1:49 AM, Stephen Boyd wrote:
Quoting Imran Shaik (2023-10-11 02:00:27)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 3194c8beb06d..60a981ff2bac 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -667,6 +667,14 @@ config QDU_GCC_1000
           QRU1000 devices. Say Y if you want to use peripheral
           devices such as UART, SPI, I2C, USB, SD, PCIe, etc.
+config QDU_ECPRICC_1000
+       tristate "QDU1000/QRU1000 ECPRI Clock Controller"

This needs a 'depends on ARM64 || COMPILE_TEST' type of line here.


Sure, will add this in the next series.

+       select QDU_GCC_1000
+       help
+         Support for the ECPRI clock controller on QDU1000 and
+         QRU1000 devices. Say Y if you want to support the ECPRI
+         clock controller functionality such as Ethernet.
+
  config SDM_GCC_845
         tristate "SDM845/SDM670 Global Clock Controller"
         depends on ARM64 || COMPILE_TEST
diff --git a/drivers/clk/qcom/ecpricc-qdu1000.c b/drivers/clk/qcom/ecpricc-qdu1000.c
new file mode 100644
index 000000000000..e26912f3dd39
--- /dev/null
+++ b/drivers/clk/qcom/ecpricc-qdu1000.c
@@ -0,0 +1,2466 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2022-2023, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#include <linux/clk-provider.h>
+#include <linux/module.h>
+#include <linux/of.h>

What is the of.h include for? Did you mean mod_devicetable.h instead of
of_device_id?


Yes, will remove of.h and use mod_devicetable.h in the next series.

Thanks,
Imran

+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux