Hi Krzysztof, krzysztof.kozlowski@xxxxxxxxxx wrote on Mon, 16 Oct 2023 22:43:28 +0200: > On 16/10/2023 22:10, Frank Li wrote: > > On Mon, Oct 16, 2023 at 09:57:18PM +0200, Krzysztof Kozlowski wrote: > >> On 16/10/2023 21:32, Frank Li wrote: > >>> On Mon, Oct 16, 2023 at 06:30:11PM +0100, Conor Dooley wrote: > >>>> On Mon, Oct 16, 2023 at 11:24:49AM -0400, Frank Li wrote: > >>>>> In driver, compatible string is silvaco,i3c-master instead of > >>>>> silvaco,i3c-master-v1. > >>>> > >>>> And what makes the driver right & the binding wrong? AFAICT, this is an > >>>> IP sold by silvaco & the -v1 suffix was explicitly requested during > >>>> review of the binding. > >>> > >>> The driver existed for the long time. DTS files already use > >>> silvaco,i3c-master. > >>> > >>> There are two options, one change doc, the other change dts and drivers. > >>> I think change doc is easiest ways. > >>> > >>> If there are v2 in future, we can added silvaco,i3c-master-v2 in future. > >>> > >>> If everyone prefer change drivers and dts, I can work on new patch. Just > >>> break back compatiblity. > >> > >> No, because Rob explicitly pointed out too generic name. > >> https://lore.kernel.org/all/20210111200821.GA2978830@xxxxxxxxxxxxxxxxxx/ > >> > >> Is it some way to avoid implementing feedback or how does it work? Not at all, it's my (faithful) fault, I did update the bindings upon Rob request and apparently kept the previous string in the driver. After thinking again I would drop silvaco,i3c-master entirely from the driver, it was never intended to keep it. Thanks, Miquèl
