Re: [PATCH v2 3/5] arm64: dts: qcom: sdm845-mtp: switch to mbn firmware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 16, 2023 at 03:39:01PM +0200, Arnd Bergmann wrote:
> On Sun, Aug 27, 2023, at 00:19, Dmitry Baryshkov wrote:
> > We have switched most of devices to use mbn (squashed) firmware files
> > instead of spit mdt+bNN. Even this DT uses modem.mbn and a630_zap.mbn.
> > Let's switch adsp and cdsp firmware files to use .mbn format too.
> >
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> 
> I saw this pop up in the dts pull request today, and this needs
> some more clarification I think: Why does the dts have to know
> about which format the files are in? I would expect that to be
> handled by the driver internally.
> 
> From what I can tell, either the two files are compatible,
> and the driver can just try both names by manipulating that
> string, or the two are incompatible and changing the firmware
> name would also mean that the dts node and driver would
> have to be aware of the difference.
> 

The implementation does not care about the file name, it will detect
which of the two formats is being provided and load the content
accordingly.

So what this patch does is to align the firmware file name to match what
we have in linux-firmware, and what the few of us booting this device
have hacked around in /lib/firmware for (quite) a while now.

Regards,
Bjorn




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux