On Thu, Oct 12, 2023 at 12:55:56PM +0200, Ante Knezic wrote: > Add documentation for selecting reference rmii clock on KSZ88X3 devices > > Signed-off-by: Ante Knezic <ante.knezic@xxxxxxxxxxx> > --- > .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > index 41014f5c01c4..eaa347b04db1 100644 > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml > @@ -72,6 +72,25 @@ properties: > interrupts: > maxItems: 1 > > + microchip,rmii-clk-internal: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + Set if the RMII reference clock is provided internally. Otherwise > + reference clock should be provided externally. > + > +if: > + not: > + properties: > + compatible: > + enum: > + - microchip,ksz8863 > + - microchip,ksz8873 > +then: > + not: > + required: > + - microchip,rmii-clk-internal I think that what you want to express is that microchip,rmii-clk-internal is only defined for microchip,ksz8863 and microchip,ksz8873. Can't you describe that as "if: properties: compatible: (...) then: properties: microchip,rmii-clk-internal"? Also, this is a port interface property, so I would like to see it in the xMII port and not global to the switch. The KSZ8873/KSZ8863 is somewhat special in that it only contains a single xMII port, but that doesn't mean that RMII settings are switch-wide. > + > + > required: > - compatible > - reg > -- > 2.11.0 >
