On Fri Oct 13, 2023 at 1:47 PM CEST, Christopher Obbard wrote: > i2s0 fails to probe on my Radxa ROCK 4SE and ROCK Pi 4B boards with: > > rockchip-pinctrl pinctrl: pin gpio3-29 already requested by leds; cannot claim for ff880000.i2s > rockchip-pinctrl pinctrl: pin-125 (ff880000.i2s) status -22 > rockchip-pinctrl pinctrl: could not request pin 125 (gpio3-29) from group i2s0-8ch-bus-bclk-off on device rockchip-pinctrl > rockchip-i2s ff880000.i2s: Error applying setting, reverse things back > rockchip-i2s ff880000.i2s: bclk disable failed -22 > > This is due to the pinctl attempting to request a GPIO which the boards > use for a different function. > > The first patch adds a missing pinctl node i2s0_2ch_bus_bclk_off to the > RK3399 devicetree. > > The second patch sets the i2s0 pinctrl to use the new node when idle and > fixes the issue. > > > Christopher Obbard (2): > arm64: dts: rockchip: Add i2s0-2ch-bus-bclk-off pins to RK3399 > arm64: dts: rockchip: Fix i2s0 pin conflict on ROCK Pi 4 boards > > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 1 + > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++++++++++ > 2 files changed, 11 insertions(+) Thanks, works as advertised on my Rock 4SE! So for the entire series: Tested-By: Folker Schwesinger <dev@xxxxxxxxxxxxxxxxxxxxx> Kind regards, Folker
Attachment:
signature.asc
Description: PGP signature