> +properties: > + compatible: > + oneOf: > + - enum: > + - marvell,mv88e6060 The 6060 is a separate driver. Its not part of mv88e6xxx. So it should have a binding document of its own. > + '#interrupt-cells': > + description: The internal interrupt controller only supports triggering > + on IRQ_TYPE_LEVEL_HIGH > + # FIXME: what is this? this should be one cell should it not? > + # the Linux mv88e6xxx driver does not implement .irq_set_type in its irq_chip > + # so at least in that implementation the type is flat out ignored. > + const: 2 This interrupt controller is for the embedded PHYs. Its is hard wired active high. > + mdio-external: > + $ref: /schemas/net/mdio.yaml# > + unevaluatedProperties: false > + description: Marvell MV88E6xxx switches have an external mdio bus to > + access switch ports. This is used to access external PHYs attached to the ports, not the ports themselves. > + > + mdio1: > + $ref: /schemas/net/mdio.yaml# > + unevaluatedProperties: false > + description: Older version of mdio-external > + deprecated: true > + properties: > + compatible: > + const: marvell,mv88e6xxx-mdio-external The driver only looks at the compatible. It does not care what the node is called. So you are going to need to change the driver if you want this in the schema. Andrew