On Thu, Oct 12, 2023 at 08:58:14AM +0200, Javier Martinez Canillas wrote: > There are DT properties that can be shared across different Solomon OLED > Display Controller families. Split them into a separate common schema to > avoid these properties to be duplicated in different DT bindings schemas. > > Suggested-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > --- > > (no changes since v1) > > .../bindings/display/solomon,ssd-common.yaml | 42 +++++++++++++++++++ > .../bindings/display/solomon,ssd1307fb.yaml | 28 +------------ > MAINTAINERS | 1 + > 3 files changed, 44 insertions(+), 27 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/solomon,ssd-common.yaml > > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd-common.yaml b/Documentation/devicetree/bindings/display/solomon,ssd-common.yaml > new file mode 100644 > index 000000000000..677fd2b90960 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/solomon,ssd-common.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/solomon,ssd-common.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Common properties for Solomon OLED Display Controllers > + > +maintainers: > + - Javier Martinez Canillas <javierm@xxxxxxxxxx> > + > +properties: > + reg: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + # Only required for SPI > + dc-gpios: > + description: > + GPIO connected to the controller's D/C# (Data/Command) pin, > + that is needed for 4-wire SPI to tell the controller if the > + data sent is for a command register or the display data RAM > + maxItems: 1 > + > + solomon,height: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Height in pixel of the screen driven by the controller. > + The default value is controller-dependent. > + > + solomon,width: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Width in pixel of the screen driven by the controller. > + The default value is controller-dependent. > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +additionalProperties: true > \ No newline at end of file With this fixed, Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
