On 11/10/2023 20:48, Peter Griffin wrote: > Google gs101 SoC is ARMv8 mobile SoC found in the Pixel 6, > (oriole) Pixel 6a (bluejay) and Pixel 6 pro (raven) mobile > phones. It features: > * 4xA55 little cluster > * 2xA76 Mid cluster > * 2xX1 Big cluster > ... > + gpa10: gpa10-gpio-bank { > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; > + }; > + > + uart15_bus: uart15-bus-pins { > + samsung,pins = "gpa2-3", "gpa2-4"; > + samsung,pin-function = <2>; GS101_PIN_FUNC_2 > + samsung,pin-pud = <0>; GS101_PIN_PULL_NONE > + }; > + > + uart16_bus: uart16-bus-pins { > + samsung,pins = "gpa3-0", "gpa3-1", "gpa3-2", "gpa3-3"; > + samsung,pin-function = <GS101_PIN_FUNC_2>; > + samsung,pin-pud = <GS101_PIN_PULL_NONE>; But here it is correct... > + }; > + > + uart16_bus_rts: uart1-bus-rts-pins { > + samsung,pins = "gpa3-2"; > + samsung,pin-function = <GS101_PIN_FUNC_OUTPUT>; > + samsung,pin-pud = <GS101_PIN_PULL_NONE>; > + samsung,pin-val = <1>; Why do you set UART RTS pin value? > + }; > + > + uart16_bus_tx_dat: uart1-bus-tx-dat-pins { > + samsung,pins = "gpa3-1"; > + samsung,pin-val = <1>; > + }; > + Best regards, Krzysztof